Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: check block size #2302

Merged
merged 4 commits into from
Sep 9, 2024
Merged

consensus: check block size #2302

merged 4 commits into from
Sep 9, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Sep 7, 2024

Resolves #2223

@herr-seppia herr-seppia force-pushed the block_size branch 2 times, most recently from 45dcd4a to 300407b Compare September 8, 2024 12:27
node-data/src/message.rs Show resolved Hide resolved
node-data/src/ledger/faults.rs Show resolved Hide resolved
node-data/src/encoding.rs Outdated Show resolved Hide resolved
rusk/src/lib/node/rusk.rs Outdated Show resolved Hide resolved
rusk/src/lib/node/rusk.rs Show resolved Hide resolved
Additionally add `size()` for the following struct:
- Header
- Fault
- Vote
- Transaction
- Add check for block size during candidate verification
- Add bound for transactions size while generating a block
@herr-seppia herr-seppia changed the title rusk: check block size consensus: check block size Sep 9, 2024
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 1eb38b7 into master Sep 9, 2024
15 checks passed
@herr-seppia herr-seppia deleted the block_size branch September 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a block size limit
2 participants